Repository navigation
Rename FhirResourceGetHistory -> FhirResourceListHistory, implement FhirResourceGetHistory. - #2456
Conversation
lesv
left a comment
There was a problem hiding this comment.
Consider the comments, it's really the client that's poorly done. That said, I'll approve, but wish you'd provide feedback to the client as this is fairly non-idiomatic.
|
@dzlier-gcp What's the status of this API? |
|
ping |
…hirResourceGetHistory.
| <source>10</source> | ||
| <target>10</target> |
There was a problem hiding this comment.
Shouldn't this be either 8 or 11?
| "[{\"op\": \"add\", \"path\": \"/active\", \"value\": false}]"); | ||
| FhirResourceGetHistory.fhirResourceGetHistory(fhirResourceName); | ||
| // Get versionId from results of fhirResourcePatch. | ||
| String versionId; | ||
| Matcher idMatcher = Pattern.compile("\"versionId\": \"(.*)\"").matcher(bout.toString()); |
There was a problem hiding this comment.
This is fine for tests, but in samples, I'd prefer we used json objects using Guava's GSON, Jackson, or org.json JAVA-Json
lesv
left a comment
There was a problem hiding this comment.
Please change to use either Java 8 or Java 11; probably 11 as 8 is having a testing failure.
LGTM once that is done.
|
Changed to Java 11, though 8 is still Failing instead of passing without running any tests. And the Build Log is empty. |
|
Nevermind, build log populated. Invalid target release "11" |
|
Probably need to update the 1.8 in pom.xml as well. |
Java 11
|
No description provided.